Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump Qt6 from 6.4.3 to 6.5.0 (Automated PR) #3042

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Apr 6, 2023

This automated Pull Request updates the used Qt6 version to version 6.5.0.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated bundled Qt6 to version 6.5.0

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/autobuild.yml:release_assets/build_all_targets:true/config:. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@pljones pljones closed this Apr 6, 2023
@pljones pljones deleted the ci/bump-dependencies/Qt6 branch April 6, 2023 18:07
@pljones pljones restored the ci/bump-dependencies/Qt6 branch April 6, 2023 18:22
@pljones pljones reopened this Apr 6, 2023
@pljones
Copy link
Collaborator

pljones commented Apr 6, 2023

(oops 😬 )

@ann0see
Copy link
Member

ann0see commented Apr 12, 2023

Seems to need some manual updates. The Qt multimedia plugin (?) needs to be installed manually - I suppose.

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 7 times, most recently from 00785c3 to 2c99a22 Compare April 21, 2023 20:12
@pljones
Copy link
Collaborator

pljones commented Apr 21, 2023

Seems to need some manual updates. The Qt multimedia plugin (?) needs to be installed manually - I suppose.

Guess we need a new PR raised to fix the scripts for that?

@ann0see
Copy link
Member

ann0see commented Apr 21, 2023

The problem is that I don't quite see where the problem is. The multimedia dependency is in the script and I don't see that it got renamed.

@ann0see
Copy link
Member

ann0see commented Apr 26, 2023

https://github.com/jamulussoftware/jamulus/actions/runs/4768466280/jobs/8477826497#step:8:91 shows the installation of qtmultimedia but that's using another python version.

WARNING: The script normalizer is installed in '/Library/Frameworks/Python.framework/Versions/3.11/bin' which is not on PATH. seems fishy.

but e.g https://github.com/ann0see/jamulus/actions/runs/4771382652/jobs/8483282702#step:8:97 works...

@ann0see
Copy link
Member

ann0see commented Apr 26, 2023

I think the regex might be bad...

@ann0see
Copy link
Member

ann0see commented Apr 26, 2023

I believe this was it.

@ann0see
Copy link
Member

ann0see commented Apr 26, 2023

But now linking fails...
Edit: Reminds me of: #2808 (comment)

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 3 times, most recently from bed5bb3 to 7018b7e Compare April 29, 2023 20:22
@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 4 times, most recently from eaf848c to b175734 Compare May 3, 2023 20:47
@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch from b175734 to b3fb48b Compare May 3, 2023 20:59
@ann0see
Copy link
Member

ann0see commented May 4, 2023

Qt Creator happily builds with Qt 6.5 locally...

Hehe: But the build script fails!!!

It searches for qt_ar.qm - a language we don't even support...

@ann0see
Copy link
Member

ann0see commented May 4, 2023

Qt 6.5 also seems to bring more Windows Darkmode support: https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5

@ann0see
Copy link
Member

ann0see commented May 4, 2023

Ok. Seems to be a Qt bug. We're not the issue: https://bugreports.qt.io/browse/QTBUG-112204

@ann0see
Copy link
Member

ann0see commented May 4, 2023

Closing as not fixable for us.

@ann0see ann0see closed this May 4, 2023
@github-actions github-actions bot deleted the ci/bump-dependencies/Qt6 branch May 4, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants