Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert delete buttons to from QPushButton to QToolButton #3305

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

softins
Copy link
Member

@softins softins commented Jun 30, 2024

Short description of changes
This fixes the width problem on Mac for server in the connect dialog and custom directory in the settings dialog. It does so by making them consistent with the delete buttons in the Server GUI Options dialog, which already use QToolButton instead of QPushButton.

CHANGELOG: Client: Fixed the display of delete buttons on Mac

Context: Fixes an issue?
Fixes #3241

Does this change need documentation? What needs to be documented and how?
No - bug fix only

Status of this Pull Request
Ready for review

What is missing until this pull request can be merged?
Testing on all platforms to verify the buttons display correctly, and are consistent with those displayed in the server dialog.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

This fixes the width problem on Mac, and also makes them consistent
with the delete buttons in the Server GUI Options dialog.
@softins softins added this to the Release 3.11.0 milestone Jun 30, 2024
@softins softins self-assigned this Jun 30, 2024
@softins softins requested review from pljones and ann0see June 30, 2024 23:34
@softins
Copy link
Member Author

softins commented Jun 30, 2024

Connect dialog:
image

Settings dialog:
image

@pljones
Copy link
Collaborator

pljones commented Jul 1, 2024

Added to project board and set to Waiting on team.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent on Debian. Won't have access to macOS for some time...

@ann0see ann0see merged commit 4cc77a4 into jamulussoftware:main Jul 1, 2024
11 checks passed
@softins softins deleted the fix-delete-buttons branch July 1, 2024 20:58
@softins
Copy link
Member Author

softins commented Jul 1, 2024

Thanks!

@softins softins mentioned this pull request Jul 10, 2024
5 tasks
@pljones pljones added the refactoring Non-behavioural changes, Code cleanup label Jul 13, 2024
@pljones pljones added the needs documentation PRs requiring documentation changes or additions label Jul 22, 2024
@pljones pljones removed the needs documentation PRs requiring documentation changes or additions label Aug 4, 2024
@pljones
Copy link
Collaborator

pljones commented Aug 4, 2024

jamulussoftware/jamuluswebsite#1002 raised for documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Non-behavioural changes, Code cleanup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

"Delete server" button doesn't show properly on macOS
3 participants