Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrase recording options on CLI page #809

Merged

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Sep 1, 2022

Short description of changes
Applies a slightly modified version based on @pljones suggestion of the recording options on the CLI page of the website. See related issue.

Context: Fixes an issue? Related issues
Fixes: #756

Status of this Pull Request
Ready to merge

What is missing until this pull request can be merged?
Approval/review by @pljones

Does this need translation?

YES

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

Fixes: jamulussoftware#756
Co-Authored-By: Peter L Jones <pljones@users.noreply.github.com>
@ann0see ann0see added this to the Release 3.9.1 milestone Sep 1, 2022
@ann0see ann0see requested a review from pljones September 1, 2022 19:14
@ann0see ann0see linked an issue Sep 1, 2022 that may be closed by this pull request
@ann0see ann0see merged commit a02a3ab into jamulussoftware:next-release Sep 1, 2022
@ann0see ann0see deleted the patch/rephraseRecording branch September 1, 2022 20:45
@ignotus666
Copy link
Contributor

This has caused a conflict with the translations PR. Would it be possible to revert it, merge the translations PR, and then merge this one?

@ann0see
Copy link
Member Author

ann0see commented Sep 2, 2022

No. This will not resolve the conflicts, I suppose. They need to be resolved on weblate.

@ann0see
Copy link
Member Author

ann0see commented Sep 2, 2022

If I have time today, I can have a look at the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rephrase --recording on CLI Page
3 participants