-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve indentation when rendering partials #703
Conversation
not all spec tests are passing, closing... |
I've added all the tests described in this spec: https://github.com/mustache/spec/blob/master/specs/partials.yml |
This looks really promising! Adding the tests from the mustache spec project was a great addition 👍 I really feel @kevindew should get more credit for his contributions, as he wrote the first draft in #613 as you mention. At the moment, none of the commits has his name on it, which isn't quite fair in my eyes. Wondering if we should use his changes as the first commit, then add your commits as tweaks on top. That way you both get credit for your contributions, well deserved 😄 |
@phillipj |
Fully understandable! Cool 👍 |
A fix for: #562