Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start linting all test/ files as part of test script #704

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

phillipj
Copy link
Collaborator

@phillipj phillipj commented Jul 8, 2019

The huge changeset makes these changes not trivial to review, but skimming through it should give an impression this is all formatting changes, no functionality has been altered.

In an effort of ensuring consistent code style in test files as with the "production" source code, we should run eslint as part of the $ npm test script as well.

Most of the related fixes was done by eslint using the --fix argument:

$ npx eslint --fix test/**/*.js

Only special configuration tweaks for tests compared to the other source code, is to allow functions declaration without names. The rationale for allowing that in tests, is that the important reason we have them in the source code (proper stacktraces) aren't as important in test files.

In an effort of ensuring consistent code style in test files as with
the "production" source code, we should run eslint as part of the
`$ npm test` script as well.

Most of the related fixes was done by `eslint` using the `--fix` argument.

Only special configuration tweaks for tests compared to the other
source code, is to allow functions declaration without names. The
rationale for allowing that in tests, is that the important reason we
have them in the source code (proper stacktraces) aren't as important
in test files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant