Support for single global changes feed #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… collections / names with paths - janmonschke#17
… filter functions
…es at janmonschke#25, updated README.md accordingly. Did not update generated .js files, docs or example app.
|
Thx for the PR :) |
janmonschke
added a commit
that referenced
this pull request
Nov 2, 2012
Support for single global changes feed
|
Maybe the compiling didn't work because you forgot the
|
|
wow cool to see this merged :) thanks for the legwork on getting this updated Tim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to finish the work done in #25, titled "Support for single global changes feed."
Here is what I did:
I merged backbone-couchdb.coffee version 1.2.2 into version 1.1 as modified in pull request #25's changes at #25, and updated README.md accordingly as requested by Jan in #25 (comment).
I did not update the generated backbone-couchdb.js file (because I ran into an error saying Backbone was not declared and didn't know how to properly import it in the build process), docs (because I don't want to take the time to learn docco if someone else already has the ability to run it quickly), tests (because I couldn't generate the .js file and am unsure how to test the new features) or example app (because I couldn't generate the .js file). Jan, or someone else, could you do these tasks and then release a new version of backbone-couchdb? Thank you!