Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack v4.0.0-alpha support #823

Closed
wants to merge 28 commits into from
Closed

Webpack v4.0.0-alpha support #823

wants to merge 28 commits into from

Commits on Dec 13, 2017

  1. Add webpack 4 to test matrix

    But don't test webpack 4 on old node versions since it now requires 6 or
    later.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    f9608bc View commit details
    Browse the repository at this point in the history
  2. Configure rules instead of loaders

    webpack 4 drops the 'loaders' key on the config
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    292e027 View commit details
    Browse the repository at this point in the history
  3. Register plugins in webpack 4 compatible way

    webpack has a completely new plugin interface. See changes to
    wepack/tapable for in-depth.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    ba3a31e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9c8b0e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4f62917 View commit details
    Browse the repository at this point in the history
  6. Workaround for file-loader

    In the future the file-loader should move away from loadContext.options
    and this would not be needed.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    3cf2be4 View commit details
    Browse the repository at this point in the history
  7. Add required 'mode' config

    Webpack 4 now requires either 'production', 'development', or 'none'.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    6aaaa93 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1d74933 View commit details
    Browse the repository at this point in the history
  9. Remove need for warnings for no-op taps

    The new method with AsyncSeriesWaterfallHook already merges the initial
    value with the result so there's no need to worry about the result not
    being defined.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    3e4bcce View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ea3afa5 View commit details
    Browse the repository at this point in the history
  11. Change to cache tests to development mode

    Recompiling and caching only really makes sense for development builds.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    a9e3467 View commit details
    Browse the repository at this point in the history
  12. Fix non-deterministic sort test

    toposort is non-deterministic when there's a tie. Needed to allow for
    either result in the test.
    
    This happens when A and B both depend on C, dependency graph looks like:
    
          A
         /
        C
         \
          B
    
    Ideally we could pass a tie breaker sort function to toposort to fix
    this.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    a8c072b View commit details
    Browse the repository at this point in the history
  13. Add better diff matcher for fixture tests

    Previously was just doing a strait string compare which was very hard to
    tell what the differences causing the failing were.
    Graham42 committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    53ea016 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2018

  1. Configuration menu
    Copy the full SHA
    f60c7a5 View commit details
    Browse the repository at this point in the history
  2. Update fixtures for webpack 4.0.0-alpha.4

    minification is now on by default for production mode.
    Graham42 committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    a3d8f11 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Configuration menu
    Copy the full SHA
    fb24cb4 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2018

  1. Configuration menu
    Copy the full SHA
    7c78137 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Configuration menu
    Copy the full SHA
    8f1c3d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82897ad View commit details
    Browse the repository at this point in the history
  3. Make dependency sort work with webpack 4

    webpack-4.0.0-alpha.5 introduced a large refactor to chunks. This is a
    corresponding update to handle the new structure.
    
    This change introduces an API change to `chunksorter.dependency`. It now
    requires an additional parameter `chunkGroups` that is available from
    the compilation object.
    
    To read more about the CommonsChunkPlugin changes see:
    - webpack/webpack#6357
    - https://gist.github.com/sokra/1522d586b8e5c0f5072d7565c2bee693
    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    57ed63f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3794144 View commit details
    Browse the repository at this point in the history
  5. Update test fixtures

    Tests were green before this so can have higher confidence in this
    change.
    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    eb641b3 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'examples-generation' into feat/webpack-4

    Wanted to update the test fixtures to not use minification, but needed
    to go back to a stable state to do that.
    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    e623e7e View commit details
    Browse the repository at this point in the history
  7. Update test fixtures

    Appear to all be internal webpack changes.
    
    It is a bit painful to review. Certain parts may be easier to see the
    changes by using the --word-diff-regex flag. Example:
    
        git diff --word-diff-regex=[^[:space:]\"\)]+
    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    d7e2306 View commit details
    Browse the repository at this point in the history
  8. Update version of extract-text-webpack-plugin

    Need a webpack 4 compatible version.
    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    52f76cc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    20b4a1e View commit details
    Browse the repository at this point in the history
  10. Remove unneeded check

    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    b0cf532 View commit details
    Browse the repository at this point in the history
  11. Iterate in a better way over parent chunks

    Perf improvement.
    
    Using getParents() causes a full iteration over the parents Set to get
    an array. Then using map() is a second iteration over the resulting
    array. By using Array.from(iterable, mapFn) we only iterate once over
    the internal data structure of parents.
    Graham42 committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    4df601b View commit details
    Browse the repository at this point in the history