Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect 'Network interfaces per Region' limit #501

Closed
jwu2 opened this issue Nov 3, 2020 · 5 comments
Closed

Incorrect 'Network interfaces per Region' limit #501

jwu2 opened this issue Nov 3, 2020 · 5 comments

Comments

@jwu2
Copy link

jwu2 commented Nov 3, 2020

Bug Report

Version

9.0.0

Installation Method

Docker

Supporting Software Versions

3.8.6

Actual Output

Currently the limit checker queries DescribeAccountAttributes API for "max-instances" attribute, then calculate with logic below:
This limit is the greater of either the default limit (350) or your On-Demand Instance limit multiplied by 5. The default limit for On-Demand Instances is 20.

Expected Output

According to https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeAccountAttributes.html, "max-instances" attribute is no longer supported.

Instead this limit is available in Service Quotas with Quota code L-DF5E4CA3 and the default value is 5000.

Testing Assistance

Yes

@jwu2 jwu2 changed the title Incorrect Network interfaces per Region limit Incorrect 'Network interfaces per Region' limit Nov 3, 2020
@jantman
Copy link
Owner

jantman commented Dec 2, 2020

Thanks for reporting this. Yes, that's all correct. I'll work up a fix for this shortly.

jantman added a commit that referenced this issue Dec 2, 2020
Fix #501 - update for new calculation of VPC/Network interfaces per Region limit
@jantman
Copy link
Owner

jantman commented Dec 2, 2020

A fix for this issue has been merged to the develop branch and is slated for release in 10.0.0 on Monday, December 7, 2020. Anyone who is able to test the fix is strongly encouraged to do so, and comment on this issue with their results. Instructions for installing awslimitchecker from a git branch are available in the Installing for Development documentation.

@jwu2
Copy link
Author

jwu2 commented Dec 4, 2020

I have tested this check in the develop branch and can confirm it's working properly.

@jantman, thank you for very much for the fix.

@jantman
Copy link
Owner

jantman commented Dec 7, 2020

Thanks so much for the confirmation!

@jantman jantman closed this as completed in 23928b5 Dec 7, 2020
@jantman
Copy link
Owner

jantman commented Dec 7, 2020

This has been fixed in 10.0.0, which is now live on PyPI and is being built on the Docker hub right now. Thank you so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants