-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Max spot instance requests per region' limit check is out of date #502
Comments
I also ran into this and after speaking with AWS Support I can confirm that the 'Max spot instance requests per region' is no longer used by AWS. Implication: Background: |
Apologies for the delay in dealing with this. So, it looks like the spot instance limits now match up to the on-demand EC2 limits, in that they're vCPU-based. Handling this for EC2 was a pretty big task (for reference, see #432 and https://awslimitchecker.readthedocs.io/en/latest/changes.html#changelog-8-0-0-vcpu-limits ). It's a bit of a pain, because China and GovCloud don't use the vCPU units yet, so two alternate code paths need to be maintained. I'll do my best to work on this within the next few days or week. |
I've promised a release today that includes a lot of staged changes, and this isn't going to make it. I'm sorry. I'll try to get another out within the next week that includes this. |
We step into the same - adding of this will help us a lot with limits monitoring. We can help with China testing as we use both RoW and China partitions. Looking at AWS WebUI - China switched also to vCPU for Spots. |
… limits BREAKING CHANGE As mentioned in issue jantman#502, the limit "Max spot instance requests per region" was removed from AWS and replaced by the following limits, based on the number of vCPU: - All F Spot Instance Requests - All G Spot Instance Requests - All Inf Spot Instance Requests - All P Spot Instance Requests - All Standard (A, C, D, H, I, M, R, T, Z) Spot Instance Requests - All X Spot Instance Requests As a result, the usage reported by awslimitchecker is not relevant anymore. In order to fix this, this commit replaces the call to the EC2 API describe_spot_instance_requests() with a call to the CloudWatch API, since the usage of Spot requests vCPUs is now available as a metric in CloudWatch. In addition, the applied limits are now retrieved from the Service Quotas service.
… limits BREAKING CHANGE As mentioned in issue jantman#502, the limit "Max spot instance requests per region" was removed from AWS and replaced by the following limits, based on the number of vCPU: - All F Spot Instance Requests - All G Spot Instance Requests - All Inf Spot Instance Requests - All P Spot Instance Requests - All Standard (A, C, D, H, I, M, R, T, Z) Spot Instance Requests - All X Spot Instance Requests As a result, the usage reported by awslimitchecker is not relevant anymore. In order to fix this, this commit replaces the call to the EC2 API describe_spot_instance_requests() with a call to the CloudWatch API, since the usage of Spot requests vCPUs is now available as a metric in CloudWatch. In addition, the applied limits are now retrieved from the Service Quotas service.
A fix for this has been released in 12.0.0, which is now live on PyPI and Docker Hub. Thank you so much! |
… limits BREAKING CHANGE As mentioned in issue jantman#502, the limit "Max spot instance requests per region" was removed from AWS and replaced by the following limits, based on the number of vCPU: - All F Spot Instance Requests - All G Spot Instance Requests - All Inf Spot Instance Requests - All P Spot Instance Requests - All Standard (A, C, D, H, I, M, R, T, Z) Spot Instance Requests - All X Spot Instance Requests As a result, the usage reported by awslimitchecker is not relevant anymore. In order to fix this, this commit replaces the call to the EC2 API describe_spot_instance_requests() with a call to the CloudWatch API, since the usage of Spot requests vCPUs is now available as a metric in CloudWatch. In addition, the applied limits are now retrieved from the Service Quotas service.
Bug Report
Version
9.0.0
Installation Method
Docker
Supporting Software Versions
3.8.6
Actual Output
Limit of this check always returns 20.
Expected Output
Refer to https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-spot-limits.html, this is replaced by following six limits:
Testing Assistance
Yes
The text was updated successfully, but these errors were encountered: