issue #489 - Add missing RDS limits (DBInstanceRoles, DBClusterRoles, CustomEndpointsPerDBCluster and ManualClusterSnapshots)

[sebasrp]

Summary

issue #489 - Add missing RDS limits (DBInstanceRoles, DBClusterRoles, CustomEndpointsPerDBCluster and ManualClusterSnapshots). These limits are already received through the DescribeAccountAttributes API call used for other limits.

Pull Request Checklist

• All pull requests should be against the develop branch, not master.
• All pull requests must include the Contributor License Agreement (see below).
• Whether or not your PR includes unit tests:
  • Please make sure you have run the exact code contained in the PR locally, and it functions as desired.
  • Please make sure the TravisCI build passes or, if not, you've corrected any obvious problems identified by the tests.
• Code should conform to the Development Guidelines:
  • pep8 compliant with some exceptions (see pytest.ini)
  • 100% test coverage with pytest (with valid tests). If you have difficulty
    writing tests for the code, that's fine, just mention that in the summary and either
    ask for assistance, or clarify that you'd like someone else to handle the tests. PRs that
    include complete test coverage will usually be merged faster.
  • Complete, correctly-formatted documentation for all classes, functions and methods.
  • documentation has been rebuilt with tox -e docs
  • Connections to the AWS services should only be made by the class's
    connect() and connect_resource() methods, inherited from
    awslimitchecker.connectable.Connectable
  • All modules should have (and use) module-level loggers.
  • Commit messages should be meaningful, and reference the Issue number
    if you're working on a GitHub issue (i.e. "issue #x - "). Please
    refrain from using the "fixes #x" notation unless you are sure that the
    the issue is fixed in that commit.
  • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in awslimitchecker, I agree to the following terms:

• The contribution included in this request (and any subsequent revisions or versions of it)
  is being made under the same license as the awslimitchecker project (the Affero GPL v3,
  or any subsequent version of that license if adopted by awslimitchecker).
• My contribution may perpetually be included in and distributed with awslimitchecker; submitting
  this pull request grants a perpetual, global, unlimited license for it to be used and distributed
  under the terms of awslimitchecker's license.
• I have the legal power and rights to agree to these terms.

[codecov-commenter]

Codecov Report

Merging #490 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #490   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         2901      2905    +4     
  Branches       441       441           
=========================================
+ Hits          2901      2905    +4     

Impacted Files	Coverage Δ
awslimitchecker/services/rds.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93680d5...9fe498e. Read the comment docs.

[codecov-io]

Codecov Report

Merging #490 (83d00ac) into develop (aae6b84) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #490   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         2919      2923    +4     
  Branches       445       445           
=========================================
+ Hits          2919      2923    +4     

Impacted Files	Coverage Δ
awslimitchecker/services/rds.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae6b84...83d00ac. Read the comment docs.

[BenjaDiaz]

Any updated regarding this? We are currently using a custom version made from this PR, as our main interest in the tool was for monitoring ManualClusterSnapshots. We would love to see this merged.

[jantman]

Apologies for the delay, and thank you so much for the contribution. I'll try to get this merged and released in the next few days.

[jantman]

Thank you so, so much for this! It's not often that I get PRs that can be merged without any changes, and it's greatly appreciated. Apologies for this sitting for so long.