Limit items (#186)

* Lower the days * Limit the test case count * Centralize limits
jaredpar · Dec 30, 2023 · 1bce481 · 1bce481
1 parent cf60912
commit 1bce481
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/DevOps.Status/Pages/Status.cshtml.cs b/DevOps.Status/Pages/Status.cshtml.cs
@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
+using DevOps.Util.DotNet;
 using DevOps.Util.DotNet.Triage;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Mvc.RazorPages;
@@ -32,7 +33,7 @@ public async Task OnGetAsync()
 
             var todayLimit = DateTime.UtcNow - TimeSpan.FromDays(1);
             TodayCount = await context.ModelBuilds.Where(x => x.StartTime > todayLimit).CountAsync();
-            var expiredLimit = DateTime.UtcNow - TimeSpan.FromDays(30);
+            var expiredLimit = DateTime.UtcNow - TimeSpan.FromDays(DotNetConstants.MaxBuildDays);
             ExpiredCount = await context.ModelBuilds.Where(x => x.StartTime < expiredLimit).CountAsync();
         }
     }

diff --git a/DevOps.Util.DotNet/DotNetConstants.cs b/DevOps.Util.DotNet/DotNetConstants.cs
@@ -27,5 +27,8 @@ public static class DotNetConstants
         public static string AzureOrganization => "dnceng-public";
         public static string DefaultAzureProject => "public";
 
+        public const int MaxBuildDays = 14;
+        public const int MaxTestCaseCount = 200;
+        public const int MaxStringLength = 4096;
     }
 }
diff --git a/DevOps.Util.DotNet/Triage/TriageContextUtil.cs b/DevOps.Util.DotNet/Triage/TriageContextUtil.cs
@@ -14,6 +14,7 @@
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Metadata.Internal;
 using Microsoft.Extensions.Options;
+using Microsoft.VisualBasic;
 
 namespace DevOps.Util.DotNet.Triage
 {
@@ -400,8 +401,15 @@ public async Task<ModelTestRun> EnsureTestRunAsync(ModelBuildAttempt modelBuildA
             };
             Context.ModelTestRuns.Add(modelTestRun);
 
+            int count = 0;
             foreach (var dotnetTestCaseResult in testRun.TestCaseResults)
             {
+                count++;
+                if (count >= DotNetConstants.MaxTestCaseCount)
+                {
+                    break;
+                }
+
                 var testCaseResult = dotnetTestCaseResult.TestCaseResult;
                 var testResult = new ModelTestResult()
                 {
@@ -476,10 +484,9 @@ string NormalizeString(string? value)
                     return "";
                 }
 
-                var maxLen = 4096;
-                if (value.Length > maxLen)
+                if (value.Length > DotNetConstants.MaxStringLength)
                 {
-                    value = $"{value.AsSpan().Slice(0, maxLen)}...";
+                    value = $"{value.AsSpan().Slice(0, DotNetConstants.MaxStringLength)}...";
                 }
 
                 return value;