Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: support the incoming v2.0 release of flask-admin #753

Open
LeXofLeviafan opened this issue Jul 20, 2024 · 6 comments
Open

TODO: support the incoming v2.0 release of flask-admin #753

LeXofLeviafan opened this issue Jul 20, 2024 · 6 comments

Comments

@LeXofLeviafan
Copy link
Collaborator

LeXofLeviafan commented Jul 20, 2024

i18n

Currently (as of v1.6.1), flask-admin i18n depends on flask-babelex if it's present, falling back to flask-babel otherwise. Meaning, flask-babel is only used when flask-babelex is not installed. For that reason, we're doing the same thing exactly.

However, recently flask-babel repo got a breaking change merged in, removing all dependencies on flask-babelex. They're planning to make a release candidate for the next version soon (appropriately numbered v2.0, since it includes breaking changes).

We should include appropriate changes in the next (patch?) release, migrating to the new flask-admin version once it's available, and removing dependency on flask-babelex accordingly.

bootstrap

The incoming release of flask-admin is going to drop the support for Bootsrap2 & Bootstrap3 themes. We're currently using the Bootstrap3 theme, so migrating bukuserver to Bootstrap4 would be necessary.

(Note: Bootstrap4 is supported by the version of flask-admin we're currently using, so we don't need to wait for the next release of flask-admin to implement this chance)

LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Jul 20, 2024
jarun added a commit that referenced this issue Jul 20, 2024
[#753] temporarily block flake-admin-v2 & actualize install instructions
@jarun
Copy link
Owner

jarun commented Jul 20, 2024

We should include appropriate changes in the next (patch?) release, migrating to the new flask-admin version once it's available, and removing dependency on flask-babelex accordingly.

If we have enough users requiring a patch, we'll release one. Else it would be a regular release.
If there are certain steps that need to be run before the release, please share.
Otherwise, you can also make the next release. That would be simpler. Please let me know if you need any permissions.

@LeXofLeviafan
Copy link
Collaborator Author

We still haven't released a version with the fix for #729 (even though the fix was merged in April)

@jarun
Copy link
Owner

jarun commented Jul 20, 2024

Right, I am still waiting since only one user reported it... so it may not be a widespread issue right now.

@LeXofLeviafan
Copy link
Collaborator Author

Rather than not being widespread, that user noticed it immediately due to running his own tests in a package manager repo, essentially 😅

(And I guess most Buku users who visit GitHub are already used to running nightly, seeing as they couldn't install the latest version from PyPI for months if not years by that point 🤔)

@jarun
Copy link
Owner

jarun commented Jul 20, 2024

Can you make a release? Please let me know if you need anything.

Release checklist: https://github.com/jarun/buku/wiki/Release-checklist

@LeXofLeviafan
Copy link
Collaborator Author

I'd rather wait for the release of the new flask-admin version (and add support for it); it appears that in addition to i18n changes, they're also removing bootstrap3 theme support, making further changes necessary to support the new flask-admin release.

@LeXofLeviafan LeXofLeviafan changed the title TODO: remove dependency on flask-babelex TODO: support the incoming v2.0 release of flask-admin Jul 29, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 23, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 23, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 23, 2024
jarun added a commit that referenced this issue Aug 24, 2024
jarun added a commit that referenced this issue Aug 24, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 26, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 26, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 26, 2024
LeXofLeviafan added a commit to LeXofLeviafan/buku that referenced this issue Aug 27, 2024
This was referenced Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants