Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export tags in markdown format as comments #419

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

ahmedelgabri
Copy link
Contributor

@ahmedelgabri ahmedelgabri commented Nov 10, 2019

This PR adds a comment per line in .md files that includes the tags

* [Title](url) <!-- TAGS: tag1, tag2, tag3 -->

I could add this to .org mode too, but I'm not familiar with the syntax.

Closes #418

@jarun
Copy link
Owner

jarun commented Nov 10, 2019

Please fix the ci failure.

@ahmedelgabri
Copy link
Contributor Author

@jarun sure, but I'm not quite sure what is the issue, to be honest. Can you give me some pointers?

Looks like this is the failing test https://github.com/ahmedelgabri/Buku/blob/37a549d37a02f6cdcc4a1a54b36da3c3cb043360/tests/test_buku.py#L260-L283

But not sure why it's failing…

@jarun
Copy link
Owner

jarun commented Nov 10, 2019

I've re-run it again. Let's see.

@jarun
Copy link
Owner

jarun commented Nov 10, 2019

CI passed. I will review this. Also need to check documentation requirements.

@jarun jarun merged commit 38cd129 into jarun:master Nov 11, 2019
@jarun
Copy link
Owner

jarun commented Nov 11, 2019

Thank you!

@ahmedelgabri ahmedelgabri deleted the export-tags-in-files branch November 12, 2019 06:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include tags in exported files?
2 participants