Added a migration guide link to multiple done call deprecations

jasmine · Dec 14, 2021 · 57c294b · 57c294b
1 parent f3b26a0
commit 57c294b
Show file tree

Hide file tree

Showing 7 changed files with 47 additions and 15 deletions.
diff --git a/lib/jasmine-core/jasmine.js b/lib/jasmine-core/jasmine.js
@@ -933,7 +933,9 @@ x     */
           "An asynchronous function called its 'done' " +
             'callback more than once. This is a bug in the spec, beforeAll, ' +
             'beforeEach, afterAll, or afterEach function in question. This will ' +
-            'be treated as an error in a future version.\n' +
+            'be treated as an error in a future version. See' +
+            '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+            'for more information.\n' +
             '(in spec: ' +
             self.getFullName() +
             ')',
@@ -8780,7 +8782,10 @@ getJasmineRequireObj().ReportDispatcher = function(j$) {
           deprecated(
             "An asynchronous reporter callback called its 'done' callback " +
               'more than once. This is a bug in the reporter callback in ' +
-              'question. This will be treated as an error in a future version.',
+              'question. This will be treated as an error in a future ' +
+              'version. See' +
+              '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+              'for more information.',
             { ignoreRunnable: true }
           );
         }
@@ -10370,7 +10375,9 @@ getJasmineRequireObj().Suite = function(j$) {
         "An asynchronous function called its 'done' callback more than " +
         'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
         'or afterEach function in question. This will be treated as an error ' +
-        'in a future version.\n' +
+        'in a future version. See' +
+        '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+        'for more information.\n' +
         '(in suite: ' +
         this.getFullName() +
         ')';
@@ -10379,7 +10386,9 @@ getJasmineRequireObj().Suite = function(j$) {
         'A top-level beforeAll or afterAll function called its ' +
         "'done' callback more than once. This is a bug in the beforeAll " +
         'or afterAll function in question. This will be treated as an ' +
-        'error in a future version.';
+        'error in a future version. See' +
+        '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+        'for more information.';
     }
 
     this.env.deprecated(msg, { ignoreRunnable: true });

diff --git a/spec/core/SpecSpec.js b/spec/core/SpecSpec.js
@@ -538,7 +538,9 @@ describe('Spec', function() {
       "An asynchronous function called its 'done' " +
         'callback more than once. This is a bug in the spec, beforeAll, ' +
         'beforeEach, afterAll, or afterEach function in question. This will ' +
-        'be treated as an error in a future version.\n' +
+        'be treated as an error in a future version. See' +
+        '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+        'for more information.\n' +
         '(in spec: a spec)',
       { ignoreRunnable: true }
     );

diff --git a/spec/core/SuiteSpec.js b/spec/core/SuiteSpec.js
@@ -236,7 +236,9 @@ describe('Suite', function() {
         'A top-level beforeAll or afterAll function called its ' +
           "'done' callback more than once. This is a bug in the beforeAll " +
           'or afterAll function in question. This will be treated as an ' +
-          'error in a future version.',
+          'error in a future version. See' +
+          '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+          'for more information.',
         { ignoreRunnable: true }
       );
     });
@@ -258,7 +260,9 @@ describe('Suite', function() {
         "An asynchronous function called its 'done' callback more than " +
           'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
           'or afterEach function in question. This will be treated as an error ' +
-          'in a future version.\n' +
+          'in a future version. See' +
+          '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+          'for more information.\n' +
           '(in suite: the parent suite the suite)',
         { ignoreRunnable: true }
       );

diff --git a/spec/core/integration/EnvSpec.js b/spec/core/integration/EnvSpec.js
@@ -519,7 +519,9 @@ describe('Env integration', function() {
       'A top-level beforeAll or afterAll function called its ' +
       "'done' callback more than once. This is a bug in the beforeAll " +
       'or afterAll function in question. This will be treated as an ' +
-      'error in a future version.';
+      'error in a future version. See' +
+      '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+      'for more information.';
 
     spyOn(console, 'error');
     env.addReporter(reporter);
@@ -555,7 +557,9 @@ describe('Env integration', function() {
       "An asynchronous function called its 'done' " +
       'callback more than once. This is a bug in the spec, beforeAll, ' +
       'beforeEach, afterAll, or afterEach function in question. This will ' +
-      'be treated as an error in a future version.';
+      'be treated as an error in a future version. See' +
+      '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+      'for more information.';
 
     spyOn(console, 'error');
     env.addReporter(reporter);
@@ -601,7 +605,9 @@ describe('Env integration', function() {
       "An asynchronous function called its 'done' " +
       'callback more than once. This is a bug in the spec, beforeAll, ' +
       'beforeEach, afterAll, or afterEach function in question. This will ' +
-      'be treated as an error in a future version.\n' +
+      'be treated as an error in a future version. See' +
+      '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+      'for more information.\n' +
       '(in spec: a suite a spec)';
 
     spyOn(console, 'error');
@@ -644,7 +650,9 @@ describe('Env integration', function() {
     var message =
       "An asynchronous reporter callback called its 'done' callback more " +
       'than once. This is a bug in the reporter callback in question. This ' +
-      'will be treated as an error in a future version.\nNote: This message ' +
+      'will be treated as an error in a future version. See' +
+      '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+      'for more information.\nNote: This message ' +
       'will be shown only once. Set the verboseDeprecations config property ' +
       'to true to see every occurrence.';
 

diff --git a/src/core/ReportDispatcher.js b/src/core/ReportDispatcher.js
@@ -48,7 +48,10 @@ getJasmineRequireObj().ReportDispatcher = function(j$) {
           deprecated(
             "An asynchronous reporter callback called its 'done' callback " +
               'more than once. This is a bug in the reporter callback in ' +
-              'question. This will be treated as an error in a future version.',
+              'question. This will be treated as an error in a future ' +
+              'version. See' +
+              '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+              'for more information.',
             { ignoreRunnable: true }
           );
         }

diff --git a/src/core/Spec.js b/src/core/Spec.js
@@ -151,7 +151,9 @@ x     */
           "An asynchronous function called its 'done' " +
             'callback more than once. This is a bug in the spec, beforeAll, ' +
             'beforeEach, afterAll, or afterEach function in question. This will ' +
-            'be treated as an error in a future version.\n' +
+            'be treated as an error in a future version. See' +
+            '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+            'for more information.\n' +
             '(in spec: ' +
             self.getFullName() +
             ')',

diff --git a/src/core/Suite.js b/src/core/Suite.js
@@ -242,7 +242,9 @@ getJasmineRequireObj().Suite = function(j$) {
         "An asynchronous function called its 'done' callback more than " +
         'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
         'or afterEach function in question. This will be treated as an error ' +
-        'in a future version.\n' +
+        'in a future version. See' +
+        '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+        'for more information.\n' +
         '(in suite: ' +
         this.getFullName() +
         ')';
@@ -251,7 +253,9 @@ getJasmineRequireObj().Suite = function(j$) {
         'A top-level beforeAll or afterAll function called its ' +
         "'done' callback more than once. This is a bug in the beforeAll " +
         'or afterAll function in question. This will be treated as an ' +
-        'error in a future version.';
+        'error in a future version. See' +
+        '<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
+        'for more information.';
     }
 
     this.env.deprecated(msg, { ignoreRunnable: true });