Skip to content

Commit

Permalink
Notify the response ops when there is change on connector config (ela…
Browse files Browse the repository at this point in the history
…stic#175981)

Resolves: elastic#175018

This Pr adds an integration test to check the changes on connectorTypes
config, secrets and params schemas.
I used `validate.schema` field as all the connector types have it.

ConnectorTypes has config, secrets and params schemas on
`validate.schema` whereas SubActionConnectorTypes has only config and
secrets.

They have multiple params schema as well but only registered and used
during action execution.
e.g.
https://github.com/ersin-erdal/kibana/blob/main/x-pack/plugins/stack_connectors/server/connector_types/bedrock/bedrock.ts#L57

And here is the explanation why they are not listed in a definition:

https://github.com/ersin-erdal/kibana/blob/main/x-pack/plugins/actions/server/sub_action_framework/validators.ts#L38

We need to do some refactoring to list those schemas on the connector
types.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
ersin-erdal and kibanamachine authored Feb 15, 2024
1 parent 68d6ab2 commit 9488c93
Show file tree
Hide file tree
Showing 10 changed files with 11,400 additions and 14 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/actions/jest.integration.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

module.exports = {
preset: '@kbn/test/jest_integration_node',
preset: '@kbn/test/jest_integration',
rootDir: '../../..',
roots: ['<rootDir>/x-pack/plugins/actions'],
};
Loading

0 comments on commit 9488c93

Please sign in to comment.