Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAX docs tutorial: Installation #18580

Merged
merged 1 commit into from
Dec 4, 2023
Merged

JAX docs tutorial: Installation #18580

merged 1 commit into from
Dec 4, 2023

Conversation

8bitmp3
Copy link
Contributor

@8bitmp3 8bitmp3 commented Nov 17, 2023 •
edited
Loading

@jakevdp jakevdp self-assigned this Nov 17, 2023
@jakevdp jakevdp linked an issue Nov 17, 2023 that may be closed by this pull request
Tracking issue: Documentation update #18585
Open
26 tasks
@jakevdp jakevdp mentioned this pull request Nov 18, 2023
Open
26 tasks
@8bitmp3 8bitmp3 closed this Nov 28, 2023
@8bitmp3 8bitmp3 reopened this Nov 28, 2023
@8bitmp3 8bitmp3 marked this pull request as ready for review November 28, 2023 22:35
@8bitmp3 8bitmp3 requested a review from jakevdp November 28, 2023 22:35
jakevdp
jakevdp reviewed Nov 28, 2023
View reviewed changes
docs/tutorials/installation.md Outdated Show resolved Hide resolved
docs/tutorials/installation.md Outdated Show resolved Hide resolved
docs/tutorials/installation.md Outdated Show resolved Hide resolved
@8bitmp3 8bitmp3 requested a review from jakevdp December 1, 2023 22:04
jakevdp
jakevdp reviewed Dec 1, 2023
View reviewed changes
docs/tutorials/installation.md Outdated Show resolved Hide resolved
docs/tutorials/installation.md Outdated Show resolved Hide resolved
@8bitmp3 8bitmp3 force-pushed the jax-docs-new-installation branch 3 times, most recently from 0631492 to 09ac8c2 Compare December 4, 2023 21:38
@8bitmp3 8bitmp3 closed this Dec 4, 2023
@8bitmp3 8bitmp3 reopened this Dec 4, 2023
@8bitmp3 8bitmp3 requested a review from jakevdp December 4, 2023 21:43
jakevdp
jakevdp approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's make sure the doc build doesn't error, then we can get this merged. Thanks for all the work on this!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Dec 4, 2023
@copybara-service copybara-service bot merged commit 150ab68 into jax-ml:main Dec 4, 2023
19 of 20 checks passed
@8bitmp3 8bitmp3 deleted the jax-docs-new-installation branch December 5, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue: Documentation update
3 participants
@8bitmp3 @jakevdp @kokoro-team