Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL panel work #1786

Merged
merged 6 commits into from
May 18, 2023
Merged

SQL panel work #1786

merged 6 commits into from
May 18, 2023

Commits on May 17, 2023

  1. Fix confusing variable shadowing

    @living180
    living180 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    0166e4d View commit details
    Browse the repository at this point in the history

  2. Remove unused query attributes

    @living180
    living180 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    98b42f0 View commit details
    Browse the repository at this point in the history

  3. Post-process two query attributes 

    There is no reason for them to be computed when recording, so move them
to SQLPanel.generate_stats().
    @living180
    living180 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    8ed8124 View commit details
    Browse the repository at this point in the history

  4. Remove unused SQLPanel._offset attribute 

    Not used since 5aff6ee (March 2011).
    @living180
    living180 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    79afff4 View commit details
    Browse the repository at this point in the history

  5. Drop unneeded SQLPanel._num_queries attribute 

    The same information can be retrieved from len(self._queries).
    @living180
    living180 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    031dfc6 View commit details
    Browse the repository at this point in the history

  6. Improve comment in wrap_cursor() 

    More fully explain the reasoning for skipping monkey patching when
running under a Django SimpleTestCase.
    @living180
    living180 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    165ce70 View commit details
    Browse the repository at this point in the history