Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override DEBUG=True in async middleware compatibility tests #1977

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Override DEBUG=True in async middleware compatibility tests #1977

merged 1 commit into from
Aug 2, 2024

Conversation

salty-ivy
Copy link
Member

@salty-ivy salty-ivy commented Aug 2, 2024 •
edited
Loading

Description

Toggle DEBUG=True with override_settings in test_middleware_compatibility in order to let DebugToolbarMiddleware make a complete run through panels.

Fixes #1938

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

@salty-ivy salty-ivy marked this pull request as ready for review August 2, 2024 13:36
tim-schilling
tim-schilling approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can also decorate the class too rather than all the methods.

@tim-schilling tim-schilling merged commit 573a87b into jazzband:main Aug 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-schilling tim-schilling tim-schilling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salty-ivy @tim-schilling