Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvitationAdminAddForm could be improved by adding dropdown instead of integer field for inviter #259

Closed
JoGorska opened this issue Aug 8, 2024 · 1 comment
Closed

InvitationAdminAddForm could be improved by adding dropdown instead of integer field for inviter #259

JoGorska opened this issue Aug 8, 2024 · 1 comment

Comments

@JoGorska
Copy link
Contributor

JoGorska commented Aug 8, 2024

To create a new invitation in the admin field a user ID needs to be used as an inviter. It would be much more practical to use forms.ModelChoiceField instead and have a full dropdown of all users.

Alternatively, it might be worth considering adding an initial value from request.user.id.

Screenshot from 2024-08-08 07-42-31
@Flimm
Copy link
Contributor

Flimm commented Aug 8, 2024

Since there may be a large number of users, a dropdown could be unusable. It might be better to use an autocomplete field. Pull requests welcome.

JoGorska added a commit to JoGorska/django-invitations that referenced this issue Aug 8, 2024
@JoGorska
feat: jazzband#259 Replace raw_id field with autocomplete_field as it…
57e4fe8 
…'s more practical when searching for user, although may affect performance of the form in large number of sets
@Flimm Flimm closed this as completed in 378b2f5 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Flimm @JoGorska