Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MenuItem url to be callable (rebased) #112

Merged
merged 4 commits into from
Nov 27, 2022

Conversation

GabDug
Copy link
Contributor

@GabDug GabDug commented Nov 27, 2022

Hello,

I've taken the liberty to rebase what @timnyborg in #71 had done to make URLs callable, so that it can be merged for v2.X.

He is still the author of 2/3 commits, but has files moved not of the third.

Cheers!

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #112 (764faa1) into master (81f751d) will increase coverage by 0.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   89.28%   89.88%   +0.60%     
==========================================
  Files           2        2              
  Lines         168      178      +10     
  Branches       25       26       +1     
==========================================
+ Hits          150      160      +10     
  Misses          9        9              
  Partials        9        9              
Impacted Files Coverage Δ
simple_menu/tests/test_menu.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kytta
Copy link
Member

kytta commented Nov 27, 2022

Looks good to me. I'll merge it; the release should be out later today.

@kytta kytta merged commit 72e930f into jazzband:master Nov 27, 2022
@GabDug
Copy link
Contributor Author

GabDug commented Nov 27, 2022

Thanks for your reactivity @kytta !

I've noticed that neither 2.0.4 nor 2.1.0 are available on pypi. I don't know if something manual needs to be done on your side?

@kytta
Copy link
Member

kytta commented Nov 27, 2022

I've noticed that neither 2.0.4 nor 2.1.0 are available on pypi. I don't know if something manual needs to be done on your side?

Yeah, I'm not the project lead, so I can submit releases for review but not publish them. For this, either @mbeijen or @borgstrom need to act on this.

@GabDug GabDug deleted the callable-urls branch November 28, 2022 08:47
@mbeijen
Copy link
Contributor

mbeijen commented Nov 28, 2022

Hi @kytta -- thanks for all your work on django-simple-menu
I've just uploaded the new releases on pypi.

BTW I would fully endorse you if you would like to become 'project manager' for the project, so you can release to pypi yourself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants