-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MenuItem url to be callable (rebased) #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 89.28% 89.88% +0.60%
==========================================
Files 2 2
Lines 168 178 +10
Branches 25 26 +1
==========================================
+ Hits 150 160 +10
Misses 9 9
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks good to me. I'll merge it; the release should be out later today. |
Yeah, I'm not the project lead, so I can submit releases for review but not publish them. For this, either @mbeijen or @borgstrom need to act on this. |
Hi @kytta -- thanks for all your work on django-simple-menu BTW I would fully endorse you if you would like to become 'project manager' for the project, so you can release to pypi yourself! |
Hello,
I've taken the liberty to rebase what @timnyborg in #71 had done to make URLs callable, so that it can be merged for v2.X.
He is still the author of 2/3 commits, but has files moved not of the third.
Cheers!