-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second level dependencies missing on for local file packages on >= 6.3.1 #1505
Comments
I haven't looked closely yet but this might be the same issue seen in #1054 |
Maybe related, but this is new in 6.3.1, release 4 days ago. |
Thanks! Yes I see in a local updated version of PR #1385 that even there this problem persists. |
I want to avoid potentially muddying the problem by using I took your example and replaced the Verbose Log
#
# This file is autogenerated by pip-compile with python 3.9
# To update, run:
#
# pip-compile requirements.in
#
project-a @ file:///tmp/pip-tools/project-a
# via
# -r requirements.in
# project-b
project-b @ file:///tmp/pip-tools/project-b
# via -r requirements.in |
Since you've narrowed this down to the |
…s for local reqs Fixes jazzband#1505
@lindycoder Please check out |
@AndydeCleyre I just made the same change as you (plus test) in #1507. I believe it's what we want for this case. I think it may imply an untested failing case of a local package dependency + combining extras, since the dependencies will be cached prior to combining the extras. I'll need to give that a bit more thought. |
One concern I have is whether that new potential case is caused by the new fix or exists already. If it's real and new, then we'd have to consider which case we prefer breaking until we have a full solution. I'll look into a minimum test case to see if it's real and new. |
I have the same issue with 2nd level dependencies when using git+https github dependencies instead of local ones: works with I can also confirm that #1507 fixes the problem. |
Hi, unfortunately I'm also affected by this. See here a test which illustrates my situation. All tests are done with
The observation I made was: pip-tools/piptools/repositories/pypi.py Line 222 in 43e532c
Since it is not in the cache For some reasons (sorry I'm not deep in the pip-tools internals) the Haven't thought of a fix. An idea would be to find a way to make ireq hashable/comparable to make the lookup in the cache working. FYI: This is
|
@stephan-hof Thanks! Can you check your case against #1519? |
Hi, thanks for the quick reply. I can confirm that #1519 fixes the test case. Tested it also for my real case with success. Just to let you know: The |
Does #1539 fix the issue? |
@atugushev #1519 (comment) When I created this comment I had also tested #1539 and it did not fix the issue for me. |
I'm having the same problem - works ok w/ What's really strange, and I haven't been able to track down, is that if I put the requirement in one remote repo/package (via setup.py install_requires) it works, but if i put it in a nearly identical setup.py in a different repo/package w/ the same mechanism it does not work. |
What needs to happen to get some movement on this? #1519 has had a fix for this for quite some time now and it's a clear regression in pip-tools behavior between <=6.3.0 and 6.3.1+. We're currently just using 6.3.0 and having to manually comment out the stream assertion error in pypi.py (lol). Our structure is a constraints file some ordered .in files:
Here is our src.txt in 6.3.0:
And here is how it changes in 6.3.1+:
Almost all actual dependencies are missing from the rendered src.txt defeating the entire purpose of pip-tools. |
I'm also in an increasing amount of pain because of having to be pinned to an old pip-tools and pip. I hope the fix can get merged and released as soon as possible |
The fix is released as part of |
Woo, thank you so much for everyone's work - I can confirm at least that 6.8.0 is working for me! |
Hi, thank you for the great tool!
There seems to be a regression with 6.3.1 (and 6.4.0). Dependencies of dependencies don't make it to the final result when using local packages.
Below is script to reproduce, problem seems to be in pip-tools as any recent tested versions of pip (21.3 and 21.2.4) produce them same problem.
Note : Tested with absolute files to remove the problematic relative files handling issues.
Environment Versions
python:3.8-buster
docker imagePython 3.8.6
pip 21.3 from /private/tmp/pip-tools/venv/lib/python3.8/site-packages/pip (python 3.8)
pip-compile, version 6.4.0
&&pip-compile, version 6.3.1
Steps to replicate
Expected result
When it works, verbose log shows round 2 as
Actual result
When it doesn't work, verbose log shows round 2 as
The text was updated successfully, but these errors were encountered: