Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip>=20.1 support #1088

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Add pip>=20.1 support #1088

merged 1 commit into from
Apr 4, 2020

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Mar 20, 2020

Changelog-friendly one-liner: Add pip>=20.1 support.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Note codecov patch check is failed because this PR is touched uncovered lines

@atugushev atugushev added the enhancement Improvements to functionality label Mar 20, 2020
@atugushev atugushev added this to the 5.0.0 milestone Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #1088 into master will increase coverage by 0.00%.
The diff coverage is 84.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          34       34           
  Lines        2443     2453   +10     
  Branches      302      306    +4     
=======================================
+ Hits         2429     2439   +10     
  Misses          8        8           
  Partials        6        6           
Impacted Files Coverage Δ
piptools/repositories/pypi.py 93.78% <69.23%> (+0.07%) ⬆️
piptools/repositories/local.py 96.22% <100.00%> (+0.22%) ⬆️
piptools/scripts/compile.py 100.00% <100.00%> (ø)
piptools/scripts/sync.py 100.00% <100.00%> (ø)
piptools/utils.py 100.00% <100.00%> (ø)
tests/test_repository_pypi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a4f7b...d60d416. Read the comment docs.

@atugushev atugushev marked this pull request as ready for review April 3, 2020 20:38
@atugushev
Copy link
Member Author

@jazzband/pip-tools

pip==20.1 is on the way pypa/pip#7951 so this PR is ready to review!

@atugushev atugushev changed the title WIP: Add pip>=20.1 support Add pip>=20.1 support Apr 3, 2020
@auvipy auvipy merged commit d119aff into jazzband:master Apr 4, 2020
@atugushev
Copy link
Member Author

Thanks, @auvipy.

@atugushev atugushev deleted the pip-20.1 branch April 4, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants