Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back piptools._compat.contextlib #1338

Merged
merged 2 commits into from
Mar 7, 2021

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Mar 6, 2021

The module pip._vendor.contextlib2 has been recently removed in pypa/pip#9384, which breaks pip-tools (see failing cron jobs for the pip's master branch).

This PR brings back the piptools._compat.contextlib.nullcontext() conext manager removed in #1283 .

/cc @jdufresne

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #1338 (f821c17) into master (9aeeed1) will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
- Coverage   99.62%   99.21%   -0.42%     
==========================================
  Files          33       33              
  Lines        2929     2927       -2     
  Branches      319      319              
==========================================
- Hits         2918     2904      -14     
- Misses          5       11       +6     
- Partials        6       12       +6     
Impacted Files Coverage Δ
piptools/repositories/pypi.py 92.51% <100.00%> (-4.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aeeed1...f821c17. Read the comment docs.

@atugushev atugushev added this to the 6.0.0 milestone Mar 6, 2021
@atugushev atugushev merged commit 4f89da8 into jazzband:master Mar 7, 2021
@atugushev atugushev deleted the revert-back-compat-contextlib branch March 7, 2021 02:43
@atugushev
Copy link
Member Author

@jdufresne thanks!

This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants