Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove futures from fake_with_deps test packages #1499

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Oct 8, 2021

The main intention is to release setuptools<57 restriction on tests. Most users probably use fresh setuptools, so should we. Also:

  1. futures package is not supposed to work on python 3 and is not installable
  2. old futures versions breaks setuptools during installation, see details: [BUG] new release (57) breaks piptools pytest pypa/setuptools#2687 (comment)
Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the tests Testing and related things label Oct 8, 2021
@atugushev atugushev requested a review from nicoa October 8, 2021 19:34
@atugushev atugushev force-pushed the fix-test-with-latest-setuptools branch from 3e7f168 to 78a2262 Compare October 9, 2021 06:12
The latest version has python_requires in `setup.py`, which fixes
failing test_realistic_complex_sub_dependencies on the latest `setuptools`.
@atugushev atugushev force-pushed the fix-test-with-latest-setuptools branch from 78a2262 to 2599d90 Compare October 9, 2021 06:13
@atugushev atugushev changed the title Remove futures from fake_with_deps test packages Update futures pinned version in fake_with_deps package Oct 9, 2021
@atugushev atugushev changed the title Update futures pinned version in fake_with_deps package Update futures pinned version in fake_with_deps package Oct 9, 2021
@atugushev
Copy link
Member Author

atugushev commented Oct 10, 2021

Ouch, this pypa/setuptools#2687 (comment) broke the test again... It's better to save time and energy and remove this.

@atugushev atugushev changed the title Update futures pinned version in fake_with_deps package Remove futures from fake_with_deps test packages Oct 10, 2021
@atugushev atugushev added this to the 6.4.0 milestone Oct 10, 2021
Copy link
Contributor

@nicoa nicoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

thx for investigating further into this @atugushev (also over there at setuptools and pythonfutures)!

@atugushev atugushev added the skip-changelog Avoid listing in changelog label Oct 11, 2021
@atugushev atugushev merged commit c02e292 into jazzband:master Oct 11, 2021
@atugushev
Copy link
Member Author

Thank you @nicoa 🙏🏻

@atugushev atugushev deleted the fix-test-with-latest-setuptools branch October 11, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants