Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extras when formatting a url direct reference #1520

Closed

Conversation

richafrank
Copy link
Contributor

As specified by the grammar in https://www.python.org/dev/peps/pep-0508/ :

url_req       = name wsp* extras? wsp* urlspec wsp+ quoted_marker?
urlspec       = '@' wsp* <URI_reference>
extras        = '[' wsp* extras_list? wsp* ']'

For #1518 , if folks agree with the change.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@AndydeCleyre
Copy link
Contributor

I'm on my phone right now and can't be sure, but this might also be sitting in #1329 which had to touch on this.

@richafrank
Copy link
Contributor Author

@AndydeCleyre Yep, I see it! (FWIW you don't need the generator expression.) Sounds like we're in agreement on the behavior. Feel free to use yours instead, unless you want to pull this in sooner.

@AndydeCleyre
Copy link
Contributor

Thanks, I'll nix the pointless generator and merge latest / rebase within a day.

I don't want to merge #1329 until @atugushev clears it; he can decide whether to merge this one beforehand.

@atugushev
Copy link
Member

Superseded by #1582.

@atugushev atugushev closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants