Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the importlib.metadata metadata implementation #1632

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented May 28, 2022

enabled by pip 22.1 by default on Python 3.11 (or later)

See https://pip.pypa.io/en/stable/news/#v22-1

To fix the failing CI / Ubuntu / 3.11-dev / latest (push) row of the test matrix.

Thoughts on adding a row to the test matrix for 3.11 with _PIP_USE_IMPORTLIB_METADATA = 0 to ensure that that flag is picked up? In theory that's an implementation detail of pip itself.

xref #1607

Contributor checklist
  • Provided the tests for the changes. (Existing tests already fail.)
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@richafrank richafrank added maintenance Related to maintenance processes dependency Related to a dependency labels May 28, 2022
@richafrank
Copy link
Contributor Author

The remaining major failure TypeError("Message.__new__() missing 1 required positional argument: 'orig'") is because combine_install_requirements is failing to deepcopy the _metadata attribute of the InstallRequirement accumulator, which is now of type importlib.metadata._adapters.Message. A local rebase seems to confirm that this is solved by #1519.

@atugushev atugushev added feature and removed maintenance Related to maintenance processes dependency Related to a dependency labels May 30, 2022
enabled by pip 22.1 by default on Python 3.11 (or later)
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev merged commit b9e38f4 into jazzband:master Jun 4, 2022
@richafrank richafrank deleted the importlib-metadata branch June 4, 2022 12:19
@richafrank
Copy link
Contributor Author

(xref pypa/pip#11044)

@atugushev atugushev changed the title Support for the importlib.metadata metadata implementation Support for the importlib.metadata metadata implementation Jun 7, 2022
@atugushev atugushev added this to the 6.7.0 milestone Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants