Fix missing vias when more than two input files are used

[lpulley]

Fixes #1853.

The gist of the problem is that

self._constraints_map = {key_from_ireq(ireq): ireq for ireq in constraints}

only kept the last ireq for each key, rather than combining them (and thus their sources).

There are two changes here:

• self._constraints_map is no longer constructed directly from constraints; rather, the items in constraints are first grouped by key into sets, then those sets are "collapsed" via combine_install_requirements() into single InstallRequirements.
• pinned_ireq._source_ireqs is no longer always a singleton list of the value from self._constraints_map; rather, if the constraint has _source_ireqs, then that list is used as pinned_ireq._source_ireqs. This effectively "unwraps" _source_ireqs (once) if possible.
  • A more sophisticated solution might be to just have writer.py recurse on _source_ireqs when constructing required_by, but that touches more code paths than are necessary to fix this, so I opted for this solution instead. Such recursion would enable combined InstallRequirements to be combined further without issue, but that doesn't seem to be a requirement right now.

The new test_many_inputs_includes_all_annotations is parametrized for 2, 3, and 10 inputs; the 2 case was not broken but should still be tested.

---

Contributor checklist

• Provided the tests for the changes.
• Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

• Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
• Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

[atugushev]

Otherwise, great work! Thanks for the fix 🎉

[lpulley]

@atugushev I see this just missed inclusion in 6.14.0 -- any chance of a 6.14.1 to release this sooner rather than later?

And thanks for your review 🙂

[atugushev]

@lpulley unfortunately no. The next release will be 7.0.0.