Ignore pkg-resources Fixes #389 #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das-g
reviewed
Jan 17, 2017
| @@ -13,6 +13,7 @@ | |||
| 'pip-review', | |||
| 'setuptools', | |||
| 'wheel', | |||
| 'pkg-resources', | |||
There was a problem hiding this comment.
Should this be marked as a workaround for an alleged Ubuntu bug or would ignoring pkg-resources be a good idea even independent of that?
There was a problem hiding this comment.
probably to ignore all the blacklisted packages from PyPI
|
Done with PR #555 |
suutari-ai
pushed a commit
to suutari/prequ
that referenced
this pull request
Sep 28, 2017
Remove entry of jazzband#437 as same change is now already mentioned earlier in the 1.10.0 change list (entry with issue number jazzband#555).
suutari-ai
pushed a commit
to suutari/prequ
that referenced
this pull request
Sep 28, 2017
* pip-tools-integration: CHANGELOG: Remove "Ignore pkg-resources (jazzband#437)" entry Update ChangeLog for the last merge Do not allow conflicting pinned versions Update release date for 1.10.1. Fixed bug breaking pip-sync on Python 3, raising TypeError Added release date for 1.10.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.