Fix unicode encoding errors inside pip (Copy of #567) #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python 2, if a distribution package contains non-ASCII file names,
the Resolver failed with the following UnicodeDecodeError, because
RequirementSet was initialized with unicode paths rather than str.
Fix this by making sure that the path components used in PyPIRepository
are all filesystem encoded str.
Drop the unicode_literals import from `_compat/tempfile.py`, because the
strings used in there should also be str, not unicode.
Also make sure that the InstallRequirement is always constructed from
str, not unicode.
Traceback of the error looked like this:
Traceback (most recent call last):
File ".../piptools/scripts/compile.py", line 184, in cli
results = resolver.resolve(max_rounds=max_rounds)
File ".../piptools/resolver.py", line 107, in resolve
has_changed, best_matches = self._resolve_one_round()
File ".../piptools/resolver.py", line 195, in _resolve_one_round
for dep in self._iter_dependencies(best_match):
File ".../piptools/resolver.py", line 274, in _iter_dependencies
dependencies = self.repository.get_dependencies(ireq)
File ".../piptools/repositories/pypi.py", line 145, in get_dependencies
self._dependencies_cache[ireq] = reqset._prepare_file(self.finder, ireq)
File ".../pip/req/req_set.py", line 620, in _prepare_file
session=self.session, hashes=hashes)
File ".../pip/download.py", line 821, in unpack_url
hashes=hashes
File ".../pip/download.py", line 663, in unpack_http_url
unpack_file(from_path, location, content_type, link)
File ".../pip/utils/__init__.py", line 605, in unpack_file
untar_file(filename, location)
File ".../pip/utils/__init__.py", line 551, in untar_file
path = os.path.join(location, fn)
File "/usr/local/lib/python2.7/posixpath.py", line 73, in join
path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 66:
ordinal not in range(128)
Fixes jazzband#564
This was referenced Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of the PR #567 from @suutari-ai, rebased on master, with the changelog entry.
Fixes #564
Fixes #433
Contributor checklist