Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacing password to asterisks in pip-compile #808

Merged
merged 1 commit into from
May 4, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented May 4, 2019

Fixes #801

Changelog-friendly one-liner: Fix replacing password to asterisks in pip-compile.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@auvipy auvipy added this to the 3.7.0 milestone May 4, 2019
@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #808 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   98.77%   98.78%   +<.01%     
==========================================
  Files          35       35              
  Lines        2044     2050       +6     
  Branches      262      262              
==========================================
+ Hits         2019     2025       +6     
  Misses         15       15              
  Partials       10       10
Impacted Files Coverage Δ
piptools/utils.py 100% <100%> (ø) ⬆️
tests/test_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1a8ef...e203f64. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #808 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   98.77%   98.78%   +<.01%     
==========================================
  Files          35       35              
  Lines        2044     2050       +6     
  Branches      262      262              
==========================================
+ Hits         2019     2025       +6     
  Misses         15       15              
  Partials       10       10
Impacted Files Coverage Δ
piptools/utils.py 100% <100%> (ø) ⬆️
tests/test_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1a8ef...e203f64. Read the comment docs.

@auvipy auvipy merged commit 12d1ea2 into jazzband:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile replaces password in URL with ****
2 participants