Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Remove non-ascii characters #816

Merged
merged 1 commit into from
May 13, 2019
Merged

README: Remove non-ascii characters #816

merged 1 commit into from
May 13, 2019

Conversation

AbdealiLoKo
Copy link
Contributor

@AbdealiLoKo AbdealiLoKo commented May 13, 2019

Make the README pure ascii (remove non-ascii characters) to avoid UnicodeDecodeError issues in some systems.

Fixes #815

Changelog-friendly one-liner: Fix issues with UnicodeError when installing from source in some systems.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #816 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          36       36           
  Lines        2153     2153           
  Branches      276      276           
=======================================
  Hits         2128     2128           
  Misses         15       15           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804d780...8a6bca8. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #816 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          36       36           
  Lines        2153     2153           
  Branches      276      276           
=======================================
  Hits         2128     2128           
  Misses         15       15           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804d780...8a6bca8. Read the comment docs.

@atugushev atugushev added this to the 3.7.1 milestone May 13, 2019
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing this.

@auvipy auvipy merged commit a938fd3 into jazzband:master May 13, 2019
@atugushev atugushev added docs Documentation related bug fix labels May 15, 2019
@atugushev atugushev modified the milestones: 3.7.1, 3.8.0 May 30, 2019
@atugushev
Copy link
Member

pip-tools v3.8.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing pip-tools from source gives UnicodeDecodeError
3 participants