Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output file update on dry-run compile #842

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jul 4, 2019

Fixes #841

Changelog-friendly one-liner: Fix output file update in dry-run mode in pip-compile

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 3.9.0 milestone Jul 4, 2019
@atugushev atugushev force-pushed the fix-erase-outputfile-on-upgrade branch from e8bd023 to 3e632c5 Compare July 5, 2019 10:25
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #842 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   98.84%   98.76%   -0.08%     
==========================================
  Files          36       36              
  Lines        2172     2194      +22     
  Branches      285      285              
==========================================
+ Hits         2147     2167      +20     
- Misses         15       16       +1     
- Partials       10       11       +1
Impacted Files Coverage Δ
piptools/utils.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
tests/test_sync.py 98.74% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becc4dc...3e632c5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 5, 2019

Codecov Report

Merging #842 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   98.84%   98.76%   -0.08%     
==========================================
  Files          36       36              
  Lines        2172     2194      +22     
  Branches      285      285              
==========================================
+ Hits         2147     2167      +20     
- Misses         15       16       +1     
- Partials       10       11       +1
Impacted Files Coverage Δ
piptools/utils.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️
tests/test_sync.py 98.74% <0%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becc4dc...3e632c5. Read the comment docs.

@auvipy auvipy merged commit 01d5c09 into jazzband:master Jul 5, 2019
@atugushev
Copy link
Member Author

atugushev commented Jul 17, 2019

pip-tools v3.9.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants