Fix crash when loading databook from XLS

`xlrd.open_workbook()` function expects the `file_contents` argument to be a string. Fixes #522
jazzband · Sep 23, 2023 · 95efc7b · 95efc7b
1 parent 5431834
commit 95efc7b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/tablib/formats/_xls.py b/src/tablib/formats/_xls.py
@@ -100,7 +100,7 @@ def import_book(cls, dbook, in_stream, headers=True):
 
         dbook.wipe()
 
-        xls_book = xlrd.open_workbook(file_contents=in_stream)
+        xls_book = xlrd.open_workbook(file_contents=in_stream.read())
 
         for sheet in xls_book.sheets():
             data = tablib.Dataset()

diff --git a/tests/test_tablib.py b/tests/test_tablib.py
@@ -1147,6 +1147,11 @@ def test_xls_import_with_errors(self):
             ])
         )
 
+    def test_book_import_from_stream(self):
+        in_stream = self.founders.xls
+        book = tablib.Databook().load(in_stream, 'xls')
+        self.assertEqual(book.sheets()[0].title, 'Founders')
+
 
 class XLSXTests(BaseTestCase):
     def test_xlsx_format_detect(self):