Fixes #567 - Implement ods import #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 92.11% 92.40% +0.29%
==========================================
Files 28 28
Lines 2827 2938 +111
==========================================
+ Hits 2604 2715 +111
Misses 223 223
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hugovk
reviewed
Oct 27, 2023
| saved_registry = registry._formats.copy() | ||
| try: | ||
| del registry._formats['ods'] | ||
| msg = (r"The 'ods' format is not available. You may want to install the " |
There was a problem hiding this comment.
Suggested change
| msg = (r"The 'ods' format is not available. You may want to install the " | |
| msg = (r"The ODS format is not available. You may want to install the " |
There was a problem hiding this comment.
If we change here, then we must also change the generation of error message in Registry.get_format (replacing '{key}' by {key.upper()}). Would you suggest that? In this PR?
There was a problem hiding this comment.
Nice but not essential! This or another is fine :)
claudep
force-pushed
the
ods_import
branch
2 times, most recently
from
11746fc
to
ce04281
Compare
|
@hugovk Thanks for pushing me to add more tests, I also had to substantially change the code for more corner cases. |
hugovk
reviewed
Oct 28, 2023
hugovk
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.