automatically create bzlmod archive for release #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeder
approved these changes
Oct 12, 2023
| # See: https://blog.bazel.build/2023/02/15/github-archive-checksum.html | ||
| bazel-release-archive: | ||
| runs-on: ubuntu-latest | ||
| continue-on-error: true |
There was a problem hiding this comment.
What effect will this have? Does this mean, if there's an error in creating this archive, but no errors anywhere else in the release, then the release will go through without an archive?
There was a problem hiding this comment.
You know what, if there's a problem, someone can always submit a patch.
There was a problem hiding this comment.
so sorry! I didn't see your review. Must've got lost in my github notifications.
I've added this to a few repositories and one of them requested I add continue-on-error and I mistakenly left it in this PR 😅
There was a problem hiding this comment.
Ha no worries. If it's not necessary, can you submit another PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps out by creating stable archive for bzlmod releases in the future
related to #1229
more details why the bazel central registry requires this is here: https://blog.bazel.build/2023/02/15/github-archive-checksum.html