fix: parse files with '\r' symbols as line ending correctly #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGSSGene
force-pushed
the
fix/crlineencoding
branch
2 times, most recently
from
326f4ab
to
9e09d8b
Compare
jbeder
approved these changes
Aug 22, 2024
|
Nice! Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1309
The stream class only considers '\n' as new lines. This works as long as the line ending is '\n' or '\r\n'.
But for files with only '\r' (as with old mac text files) it doesn't work as expected.
This PR extends the stream class. It remembers the first '\r' or '\n' encounter and uses that as a line ending.