Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build debug messages #1316

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Remove build debug messages #1316

merged 1 commit into from
Aug 27, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 27, 2024

They were commented out before 0733aeb, but when that commit was reverted in 2b65c65 they were recovered uncommented.

@orgads
Copy link
Contributor Author

orgads commented Aug 27, 2024

@jbeder please review

@jbeder
Copy link
Owner

jbeder commented Aug 27, 2024

I'm not sure I understand this; aren't they already essentially commented with the #pragma?

@orgads
Copy link
Contributor Author

orgads commented Aug 27, 2024

No. #pragma message instructs the compiler to print a message on stderr. See gcc doc and MSVC doc.

@orgads
Copy link
Contributor Author

orgads commented Aug 27, 2024

This is how the build looks like:

[327/2653] Building CXX object src\plugins\clangtools\CMakeFiles\yaml-cpp.dir\__\__\libs\3rdparty\yaml-cpp\src\regex_yaml.cpp.obj
Defining YAML_CPP_API for DLL export
[328/2653] Building CXX object src\plugins\clangtools\CMakeFiles\yaml-cpp.dir\__\__\libs\3rdparty\yaml-cpp\src\ostream_wrapper.cpp.obj
Defining YAML_CPP_API for DLL export
[329/2653] Building CXX object src\plugins\clangtools\CMakeFiles\yaml-cpp.dir\__\__\libs\3rdparty\yaml-cpp\src\parse.cpp.obj
Defining YAML_CPP_API for DLL export
[330/2653] Building CXX object src\plugins\clangtools\CMakeFiles\yaml-cpp.dir\__\__\libs\3rdparty\yaml-cpp\src\scanner.cpp.obj
Defining YAML_CPP_API for DLL export
...

@jbeder
Copy link
Owner

jbeder commented Aug 27, 2024

Sorry, I meant that it doesn't actually affect the build (outside of the message).

It sounds like you don't want the message? I suppose we can delete it if you like. Why comment it out?

@orgads
Copy link
Contributor Author

orgads commented Aug 27, 2024

I thought maybe you would want it for debugging the build.

If you don't care about it, I'll delete it.

They were commented out before 0733aeb, but when that commit
was reverted in 2b65c65 they were recovered uncommented.
@orgads
Copy link
Contributor Author

orgads commented Aug 27, 2024

Done

@orgads orgads changed the title Comment out debug messages Remove build debug messages Aug 27, 2024
@jbeder jbeder merged commit 47cd272 into jbeder:master Aug 27, 2024
33 checks passed
@orgads orgads deleted the no-pragma-message branch August 27, 2024 17:38
qtprojectorg pushed a commit to qt-creator/qt-creator that referenced this pull request Aug 28, 2024
They pollute the build output.

Upstream PR: jbeder/yaml-cpp#1316

Change-Id: Ib3a72a1c92c878b2b1d18cb95e588dba7b166395
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: hjk <hjk@qt.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants