Misc commit status API fixes

[cvrebert]

Fixes #1128 by addressing these various minor issues.

[dmarkov]

@cvrebert Thanks, someone will review your pull request soon

[dmarkov]

@pinaf please review

[pinaf]

@cvrebert we need the issue number and time estimate here. @todo #1129:30min blah...

[cvrebert]

Done

[pinaf]

@cvrebert 2 comments above

[pinaf]

@cvrebert why was Statuses.Smart removed?

[cvrebert]

why was Statuses.Smart removed?

@pinaf Because after removing 2 broken methods from it, all the remaining methods just delegated to the Statuses object. It offers no additional methods/features compared to a plain Statuses object, so there's no reason for it to exist.

[cvrebert]

@pinaf I've responded to all of your comments.

[pinaf]

@cvrebert thanks

[pinaf]

@rultor merge

[rultor]

@rultor merge

@pinaf Thanks for your request. @yegor256 Please confirm this.

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

[dmarkov]

@cvrebert there is a puzzle in this code 1129-3099cf0b/#1133, we'll resolve it later

[dmarkov]

@pinaf Thanks for your contribution, 19 mins was added to your account, payment ID is AP-0RN2846820363222D, 24 hours and 42 mins spent total. review comments (c=4) added as a bonus. +19 added to your rating, current score is: +7295

[dmarkov]

@rultor deploy now pls

[rultor]

@rultor deploy now pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy now pls

@dmarkov Done! FYI, the full log is here (took me 5min)

[0pdd]

@cvrebert the puzzle #unknown is still not solved.

[0pdd]

@cvrebert the puzzle #1785 is still not solved.