Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array, ArraySet and ArrayMap should get rid of "instanceof" #14

Open
super132 opened this issue May 27, 2015 · 1 comment
Open

Array, ArraySet and ArrayMap should get rid of "instanceof" #14

super132 opened this issue May 27, 2015 · 1 comment

Comments

@super132
Copy link
Contributor

The constructor of Array, ArraySet and ArrayMap uses instanceof for doing different logics according to different input which implements Iterable. This can be avoided by creating 2 new constructors taking Collection and other class and put the logic there.
@super132 super132 changed the title Array, ArraySet and ArrayMap should get rid of instanceof Array, ArraySet and ArrayMap should get rid of instanceof May 27, 2015
@super132 super132 changed the title Array, ArraySet and ArrayMap should get rid of instanceof Array, ArraySet and ArrayMap should get rid of "instanceof" May 27, 2015
@dmarkov
Copy link

dmarkov commented Jun 15, 2015

@yegor256 dispatch this issue please

alexwirz pushed a commit to alexwirz/jcabi-immutable that referenced this issue Oct 14, 2017
Fixed issue jcabi#14
2d6475d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmarkov @super132