Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#37 Limitation: Encapsulated objects with exposed mutators can mutate #39

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

pluresideas
Copy link
Contributor

…te their state

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@0crat
Copy link

0crat commented Aug 16, 2020

@yegor256/z everybody who has role REV is banned at #39; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 21, 2020

@yegor256/z everybody who has role REV is banned at #39; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 26, 2020

@yegor256/z everybody who has role REV is banned at #39; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented Aug 31, 2020

@yegor256/z everybody who has role REV is banned at #39; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@pluresideas
Copy link
Contributor Author

@yegor256 I am not sure what the 0crat messages mean. Is anything else needed from my side?

@yegor256 yegor256 merged commit 998b6ce into jcabi:master Sep 1, 2020
@yegor256
Copy link
Member

yegor256 commented Sep 1, 2020

@pluresideas that's it, thanks!

@0crat
Copy link

0crat commented Sep 1, 2020

Job gh:jcabi/jcabi-immutable#39 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants