-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Jakarta EE 9.1 and higher #60
Add support for Jakarta EE 9.1 and higher #60
Conversation
@yegor256 May I ask your help reviewing this, please? |
@melbeltagy I'm a bit scared here, since we totally move away from "standard" API. Is it possible to somehow maintain backward compatibility? WDYT? |
Thank you @yegor256 for the quick reply. I'm not sure what you mean by "standard" API, to be honest. Regarding backwards compatibility, I am open for any suggestions on how to achieve it. The issue is that I think what we can do is have two separate versions:
WDYT? |
@yegor256 Any thoughts/updates regarding this PR, please? |
@yegor256 I can see that Version 2.0 is created and still doesn't have a Jakarta EE support. We tried using version 1.x of the library with Spring Boot 3.x, but it didn't work due to Your input/support with this topic is highly appreciated. |
@melbeltagy how about instead of modifying the existing |
@yegor256 That sounds like a good idea. Having both classes, and both dependencies. But since these packages cannot be used together on the same classpath, how would we configure the build in this case, please? Edit: I guess your hint to the |
@melbeltagy why not? I mean, in a webapp they definitely should not stay together on the classpath. But in this library they can easily co-exist on classpath during compilation, I believe. |
@yegor256 Thank you so much. The PR is now updated according to your recommendations and uses Also, the deprecated methods in Please let me know if something else is missing and requires to be updated. |
@rultor merge |
@rultor release, tag is |
@melbeltagy it's released, thanks for your contribution! |
This PR adds support for Jakarta EE Servlet API as a replacement for the previous JavaEE Servlet API (package change
javax.servlet
->jakarta.servlet
)It can be used by Jakarta EE 9.1 and higher
Notes: