This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
feat: introduce RigidBodyDominance component #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agg23
changed the title
agg23
changed the title
|
I could see this turning into a |
jcornaz
suggested changes
Apr 14, 2022
Comment on lines
+352
to
+356
| #[derive(Debug, Component, Copy, Clone, Default, Reflect)] | ||
| pub struct RigidBodyDominance { | ||
| /// The dominance of the rigid body. The higher value in a collision will dominate | ||
| pub dominance: i8, | ||
| } |
There was a problem hiding this comment.
I think here I would prefer to have the field private and implement From<i8> for RigidBodyDominance and From<RigidBodyDominance> for i8.
So that we promise a little bit less, and keep the door open to change the internal representation.
|
Heron is now discontinued. Sorry this change never got merged. Thank you for your interest in the project and your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rapier3d supports a dominance property (dimforge/rapier#122) that is used in collisions between two dynamic
RigidBodys. If one body's dominance is higher than the other, that body will not experience any forces in the collision, acting as if it has infinite mass.This PR adds a small
RigidBodyDominancecomponent to support setting this property. In particular, this helps address #96, allowing your player body to ignore forces exerted by other dynamic bodies colliding with it.