Render icons in Button based on the type prop
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the buttons have their icons fixed for a given type to ease UX. For example,
deletetype buttons are always rendered with thetrashicon, or theviewbuttons are always rendered with theeyeicon and similarly thesavebuttons are always rendered with thesave (floppy)icon.So instead of having to repeatedly pass the icon-name as a prop for the same Button type, it is better if the Button component determined the icon based on the current type.
Nevertheless, the existing behavior of passing
iconas a prop is still valid to allow rendering a variant of the button with a different icon if such a need arises.