Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playlist): Add Playlist Item view #1820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BrianCArnold
Copy link
Contributor

@BrianCArnold BrianCArnold commented Nov 25, 2022

This adds the feature mentioned in #1819

When opening a playlist, this shows all items in the playlist, and if the currently playing item is in the playlist, it is highlighted.

When clicking on an item in the playlist, the entire playlist is added to the queue, and the clicked item starts playing.

Click-and-drag reorders the playlist, and saves the change on the server instantly.

This also adds the ability to save any current queue to a playlist.

@jellyfin-bot jellyfin-bot added frontend:store Pull requests or issues that deal with stores vue Pull requests that edit or add Vue files labels Nov 25, 2022
@BrianCArnold BrianCArnold changed the title Add Playlist Item view feat(playli) Add Playlist Item view Nov 25, 2022
@BrianCArnold BrianCArnold changed the title feat(playli) Add Playlist Item view feat(playlist): Add Playlist Item view Nov 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ferferga ferferga added the blocked Something depends on another issue or Pull Request label Dec 27, 2022
@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Apr 3, 2023
@ferferga ferferga removed the blocked Something depends on another issue or Pull Request label Apr 15, 2023
@ferferga ferferga force-pushed the master branch 3 times, most recently from 5e698fd to 26d3ab7 Compare May 1, 2023 22:03
@ferferga ferferga force-pushed the master branch 2 times, most recently from bc856ac to 7336bfd Compare August 16, 2023 19:17
Temporary use of CollectionTabs for playlist for testing.
Need to create new component for playlist
 * Need to display in list
 * Need to be able to drag/reorder

Got playlists working for the most part. (the skeleton display isn't quite right, though.)

Remove showing of "loading" skel during moving items.

Removed code smells.

Fixed some linting issues.

Caused an issue while trying to clean things up. Fixed now.

Got saving play queue to playlist working. :-)

Fixed lint issues.
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 46ab70b
Status 🔄 Deploying...
Preview URL Not available
Type 🔀 Preview

View bot logs

Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:store Pull requests or issues that deal with stores merge conflict Something has merge conflicts vue Pull requests that edit or add Vue files
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants