-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Search Field for Tv Mode #5610
Fix Search Field for Tv Mode #5610
Conversation
Please update this to target the release branch for 10.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my little knowledge of React 😅, looks fine.
This needs to be rebased on release-10.9.z
branch if we want it in 10.9.
27708c4
to
bbada3e
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
bbada3e
to
a51d700
Compare
Quality Gate passedIssues Measures |
Fix Search Field for Tv Mode Original-merge: 003bc94 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Changes
TV mode layout
, when the user interacts with the search fields by selecting an alphabetic characteronAlphaPicked callback
, thequery (search term)
is not updated Properly.Issues
Before
Search.mp4
After
Search.Fix.mp4