Code review #3
Open
Code review #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtion in the server
Create menu dish feature
matiasgarcia91
commented
Mar 12, 2020
src/UserCook/action.js
Outdated
| export const USERPROFILE_SIGNED_UP = "userProfile/SIGNED_UP"; | ||
| export const USERADDRESS_SIGNED_UP = "userAddress/SIGNED_UP"; | ||
|
|
||
| const baseUrl = "http://localhost:5000"; |
There was a problem hiding this comment.
with axios you can create an instance in another file where you set the baseUrl and then import axios from that file from anywhere, try it out!
// src/axios.js
import axios from "axios";
const instance = axios.create({
baseURL: "http://localhost:4000"
});
export default instance;
There was a problem hiding this comment.
got this one to work. very cool suggestion. thanks!
src/UserCook/action.js
Outdated
| userProfileData | ||
| ); | ||
|
|
||
| dispatch(userProfileSignUp_Sucess(responseData.data)); |
There was a problem hiding this comment.
if you are using camelCase for function and variables (which is the way to go) don't use underscores _
There was a problem hiding this comment.
thanks for the tip. will update and have it implemented by the next push.
| <h1>Sasha & John Digweed x World Fashion Centre Amsterdam</h1> | ||
| <p> | ||
| In an ever-evolving electronic music landscape, Sasha and John | ||
| Digweed have managed to stay as relevant as ever. After |
There was a problem hiding this comment.
you into him? he's good
Create menu dish feature
Deploy heroku cleared. please proceed
Display menu cards
Home display dishes *display dishes *shopping cart (ui display only)
added new Homepage screenshot. updated new technologies section
changed db connection to heroku
repush heroku connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.