[JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

[jglick]

See JEP-222. Alternative to #129. Works with jenkinsci/remoting#357. Requires #147.

[slide]

We will need to update the Windows side as well (https://github.com/jenkinsci/docker-jnlp-slave/blob/master/jenkins-agent.ps1)

[jglick]

Yes, I did not try that yet but I could.

[olblak]

Lgtm

[oleg-nenashev]

Please also update README

[oleg-nenashev]

Looks good to me, but the upstream pull request in Remoting needs to be released first

[jglick]

the upstream pull request in Remoting needs to be released first

Yes, this is on hold until the core changes are released.

[oleg-nenashev]

https://github.com/jenkinsci/remoting/releases/tag/remoting-4.0 must be integrated and released in the parent image: https://github.com/jenkinsci/docker-slave . Otherwise this feature will not work

[jglick]

[Remoting 4.0] must be integrated and released in the parent image

Sure. I presume someone like @jeffret-b would be doing this as a routine task.

[jeffret-b]

I was hoping to get to that today, but may have more pressing tasks.

[jglick]

I think there is no rush. This change is needed for people who wish to use WebSocket transport for agents managed by the kubernetes plugin’s cloud, which is not the typical use case. Otherwise you could just rely on the *.jnlp parsing to set -webSocket (see jenkinsci/docker-agent#693). I suppose there are other people using this launcher script for Dockerized inbound agents who could benefit. And of course it only matters if you are running 2.217+.

[jeffret-b]

I managed to squeeze it in before lunch. The PRs are up.

[jglick]

So can you merge & release this @jeffret-b, or whoever is maintaining this repo?

[jeffret-b]

I don't have permission in this repository. Maybe @slide or @oleg-nenashev

[jglick]

@MarkEWaite thanks! Now can you can a release please? 3.40-1...master

[MarkEWaite]

I would like to leave this for @oleg-nenashev to release, since he's released the most recent several versions of it and I've never released a version. If @oleg-nenashev has not been able to release it by tomorrow, I'll attempt the release.

[jglick]

ping @MarkEWaite @oleg-nenashev

[MarkEWaite]

Sorry that I missed this one @jglick. As I look at the repository, the release process is not immediately clear to me. I'll talk with @oleg-nenashev tomorrow and learn how to release from this repository.

[jglick]

I am not sure either. It may suffice to just create a tag and wait for Docker Hub automated builds to kick in.

[jglick]

IIUC from the Jenkinsfile, Linux publishing is passive, whereas a Jenkins project publishes the Windows version.

[slide]

The linux publishing should be done on dockerhub builds, though I am not sure how the tagging for specific versions takes place. For the Windows versions, we are publishing them via trusted.ci, we do not currently do a version specific release, I would need to look into that.

[oleg-nenashev]

on it

[MarkEWaite]

The 4.0.1-1 release is now available and ready to use. A CONTRIBUTING document has also been added which includes a video link to a session that describes the release process.

[jglick]

$ docker run --rm jenkinsci/jnlp-slave:4.0.1-1 2>&1 | fgrep -i websocket
 -webSocket                            : Make a WebSocket connection to Jenkins

🎉