Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstrating that API in JENKINS-44892 can be used as a replacement for the special methods in StepDescriptor #170

Merged
merged 10 commits into from
Dec 2, 2022
Merged

Demonstrating that API in JENKINS-44892 can be used as a replacement for the special methods in StepDescriptor #170

merged 10 commits into from
Dec 2, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Apr 9, 2019

@jglick jglick marked this pull request as ready for review April 9, 2019 14:44
@jglick jglick requested a review from dwnusbaum April 11, 2019 20:29
@jglick
Copy link
Member Author

jglick commented Apr 11, 2019

CI build seems to be complaining about a SpotBugs violation I cannot reproduce locally, and which only happens on Windows:

launchEnv must be non-null but is marked as nullable [org.jenkinsci.plugins.docker.workflow.client.DockerClient] At DockerClient.java:[lines 281-300] NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE

The method being called says @CheckForNull EnvVars env so I am not sure what the issue is.

oleg-nenashev
oleg-nenashev approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oleg-nenashev
oleg-nenashev reviewed Oct 9, 2019
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@jglick jglick mentioned this pull request Jan 28, 2020
Merged
@jglick jglick removed the on-hold label Aug 18, 2020
@jglick jglick mentioned this pull request Nov 9, 2020
Merged
@jglick jglick requested a review from rsandell June 10, 2022 18:03
@jglick
Copy link
Member Author

jglick commented Jun 28, 2022

ping @rsandell

@jglick jglick added the chore label Dec 1, 2022
@jglick jglick enabled auto-merge December 1, 2022 23:45
@jglick jglick merged commit 0e281f0 into jenkinsci:master Dec 2, 2022
@jglick jglick deleted the CustomDescribableModel-JENKINS-44892 branch December 2, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@dwnusbaum dwnusbaum Awaiting requested review from dwnusbaum

@rsandell rsandell Awaiting requested review from rsandell

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @oleg-nenashev