Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-58732] Complete cleanup of pipeline-model-definition dep #230

Merged
merged 5 commits into from
Feb 24, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 21, 2020

Last stage mentioned in #202. Also see jenkinsci/pipeline-model-definition-plugin#393.

@jglick jglick requested a review from dwnusbaum October 21, 2020 16:38
@jglick jglick marked this pull request as draft October 21, 2020 16:50
@jglick
Copy link
Member Author

jglick commented Oct 21, 2020

Actually this is downstream of jenkinsci/pipeline-model-definition-plugin#393: need that to be released first and used as the dep. Otherwise InjectedTest rightly complains about a cyclic dependency error.

@jglick jglick marked this pull request as ready for review February 2, 2021 19:01
@jglick
Copy link
Member Author

jglick commented Feb 15, 2021

@dwnusbaum who can get this released?

@car-roll car-roll merged commit c6b8df0 into jenkinsci:master Feb 24, 2021
@jglick jglick deleted the declarative-JENKINS-58732 branch February 24, 2021 15:43
<java.level>8</java.level>
<pipeline-model-definition-plugin.version>1.5.1</pipeline-model-definition-plugin.version>
<pipeline-model-definition-plugin.version>1.8.1</pipeline-model-definition-plugin.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could be removed at this point, picking up bom version. Just have not checked recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants