Adapt git browsers for Jetty 12 EE 9 transition (#1620)

No need to throw ServletException when checking for URL validity.
IOException is sufficient and avoids including Jakarta EE in the method
signature.

Testing done:

* Confirmed that AssemblaWeb still reports the expected message when an
  invalid URL is provided and that it reports no message when a valid
  URL is provided.  Confirmed that Assembla has changed URLs and broken
  the browsing links that previously worked. Separate bug report

* Confirmed that GitBlit browsing works as expected by installing a
  GitBlit server. https://hub.docker.com/r/gitblit/gitblit

* Confirmed that ViewGit browser provides change links as expected.
  Confirmed that the ViewGit URL check logic no longer works on the
  site used as an example.  Now reports that https://repo.or.cz/ does
  not look like a ViewGit site. Separate bug report

Did not check Gitiles because the Gitiles source repository is archived
on GitHub at https://github.com/google/gitiles .  No further development
is expected.

Did not check TFS2013 because I have no idea where to find a Team
Foundation Server 2013 installation.

Did not check Fisheye because I could not find a Fisheye server on the
public internet.

src/main/java/hudson/plugins/git/browser/AssemblaWeb.java

@@ -116,7 +116,7 @@ public FormValidation doCheckRepoUrl(@AncestorInPath Item project, @QueryParamet
                 return FormValidation.error(Messages.invalidUrl());
             }
             return new URLCheck() {
-                protected FormValidation check() throws IOException, ServletException {
+                protected FormValidation check() throws IOException {
                     String v = cleanUrl;
                     if (!v.endsWith("/")) {
                         v += '/';
@@ -129,7 +129,12 @@ protected FormValidation check() throws IOException, ServletException {
                             return FormValidation.error("This is a valid URL but it does not look like Assembla");
                         }
                     } catch (IOException e) {
-                        return FormValidation.error("Exception reading from Assembla URL " + cleanUrl + " : " + handleIOException(v, e));
+                        String prefix = "Exception reading from Assembla URL " + cleanUrl + " : ";
+                        if (e.getMessage().equals(v)) {
+                            return FormValidation.error(prefix + "Unable to connect " + v, e);
+                        } else {
+                            return FormValidation.error(prefix + "ERROR: " + e.getMessage(), e);
+                        }
                     }
                 }
             }.check();

src/main/java/hudson/plugins/git/browser/FisheyeGitRepositoryBrowser.java

@@ -108,15 +108,19 @@ public FormValidation doCheckRepoUrl(@QueryParameter(fixEmpty = true) String val
 			final String finalValue = value;
 			return new URLCheck() {
 				@Override
-				protected FormValidation check() throws IOException, ServletException {
+				protected FormValidation check() throws IOException {
 					try {
 						if (findText(open(new URL(finalValue)), "FishEye")) {
 							return FormValidation.ok();
 						} else {
 							return FormValidation.error("This is a valid URL but it doesn't look like FishEye");
 						}
 					} catch (IOException e) {
-						return handleIOException(finalValue, e);
+						if (e.getMessage().equals(finalValue)) {
+							return FormValidation.error("Unable to connect " + finalValue, e);
+						} else {
+							return FormValidation.error(e.getMessage(), e);
+						}
 					}
 				}
 			}.check();

src/main/java/hudson/plugins/git/browser/GitBlitRepositoryBrowser.java

@@ -102,7 +102,7 @@ public FormValidation doCheckRepoUrl(@AncestorInPath Item project, @QueryParamet
                 return FormValidation.error(Messages.invalidUrl());
             }
             return new URLCheck() {
-                protected FormValidation check() throws IOException, ServletException {
+                protected FormValidation check() throws IOException {
                     String v = cleanUrl;
                     if (!v.endsWith("/")) {
                         v += '/';
@@ -115,7 +115,11 @@ protected FormValidation check() throws IOException, ServletException {
                             return FormValidation.error("This is a valid URL but it doesn't look like Gitblit");
                         }
                     } catch (IOException e) {
-                        return handleIOException(v, e);
+                        if (e.getMessage().equals(v)) {
+                            return FormValidation.error("Unable to connect " + v, e);
+                        } else {
+                            return FormValidation.error(e.getMessage(), e);
+                        }
                     }
                 }
             }.check();

src/main/java/hudson/plugins/git/browser/Gitiles.java

@@ -88,7 +88,7 @@ public FormValidation doCheckRepoUrl(@AncestorInPath Item project, @QueryParamet
                 return FormValidation.error(Messages.invalidUrl());
             }
             return new URLCheck() {
-                protected FormValidation check() throws IOException, ServletException {
+                protected FormValidation check() throws IOException {
                     String v = cleanUrl;
                     if (!v.endsWith("/"))
                         v += '/';
@@ -101,7 +101,11 @@ protected FormValidation check() throws IOException, ServletException {
                             return FormValidation.error("This is a valid URL but it doesn't look like Gitiles");
                         }
                     } catch (IOException e) {
-                        return handleIOException(v, e);
+                        if (e.getMessage().equals(v)) {
+                            return FormValidation.error("Unable to connect " + v, e);
+                        } else {
+                            return FormValidation.error(e.getMessage(), e);
+                        }
                     }
                 }
             }.check();

src/main/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowser.java

@@ -140,15 +140,19 @@ public FormValidation doCheckRepoUrl(@QueryParameter(fixEmpty = true) String val
             final String finalValue = value;
             return new FormValidation.URLCheck() {
                 @Override
-                protected FormValidation check() throws IOException, ServletException {
+                protected FormValidation check() throws IOException {
                     try {
                         if (findText(open(new URL(finalValue)), "icrosoft")) {
                             return FormValidation.ok();
                         } else {
                             return FormValidation.error("This is a valid URL but it doesn't look like a Microsoft server");
                         }
                     } catch (IOException e) {
-                        return handleIOException(finalValue, e);
+                        if (e.getMessage().equals(finalValue)) {
+                            return FormValidation.error("Unable to connect " + finalValue, e);
+                        } else {
+                            return FormValidation.error(e.getMessage(), e);
+                        }
                     }
                 }
             }.check();

src/main/java/hudson/plugins/git/browser/ViewGitWeb.java

@@ -107,7 +107,7 @@ public FormValidation doCheckRepoUrl(@AncestorInPath Item project, @QueryParamet
                 return FormValidation.error(Messages.invalidUrl());
             }
             return new URLCheck() {
-                protected FormValidation check() throws IOException, ServletException {
+                protected FormValidation check() throws IOException {
                     String v = cleanUrl;
                     if (!v.endsWith("/"))
                         v += '/';
@@ -119,7 +119,11 @@ protected FormValidation check() throws IOException, ServletException {
                             return FormValidation.error("This is a valid URL but it doesn't look like ViewGit");
                         }
                     } catch (IOException e) {
-                        return handleIOException(v, e);
+                        if (e.getMessage().equals(v)) {
+                            return FormValidation.error("Unable to connect " + v, e);
+                        } else {
+                            return FormValidation.error(e.getMessage(), e);
+                        }
                     }
                 }
             }.check();